[pull] master from DataDog:master#602
Merged
Merged
Conversation
…#24056) * Properly cache and ignore DDIGNORE labeled queries * partial commit miss * remove test dashboard * Fix edge case on cache correctness
* test argocd submission * add unique identifier * better unique identifier * allow list approach * validations * argocd to submit entity metadata * Update 23917.added * remove public plication * Update metadata.csv * use a different separator * pin dcb * remove review files * fix naming * clean up * more knobs * nits * Read genresources config from pydantic and clean up reviewer findings - Defer ArgocdResourceCollector construction to the first check() call so it observes the populated pydantic config (self.config) instead of the raw instance dict; drops the hardcoded TTL / interval / cap literals that were duplicating the spec defaults. - Read collect_genresources from self.config. - Swap the volume-cap log args to read type/fetched/cap in order and use log.exception for the fetch-failure path so tracebacks survive. - Spec wording: ArgoCD (one word) and allowlist / allowlisted per the style guide. - Tests: add a _check() helper that loads the config models and attaches the collector, add coverage for the missing-endpoint path and for credential scrubbing on cluster.connectionState.message, tighten the volume-cap assertion against the new message format, and mark the file as pytest.mark.unit. * Update argocd/datadog_checks/argocd/resources.py Co-authored-by: Kyle Neale <kyle.neale@datadoghq.com> * Update argocd/datadog_checks/argocd/resources.py Co-authored-by: Kyle Neale <kyle.neale@datadoghq.com> * Update argocd/datadog_checks/argocd/resources.py Co-authored-by: Kyle Neale <kyle.neale@datadoghq.com> * Update argocd/datadog_checks/argocd/resources.py Co-authored-by: Kyle Neale <kyle.neale@datadoghq.com> --------- Co-authored-by: Kyle-Neale <kyle.neale@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )