Skip to content

[pull] master from DataDog:master#602

Merged
pull[bot] merged 2 commits into
ConnectionMaster:masterfrom
DataDog:master
Jun 16, 2026
Merged

[pull] master from DataDog:master#602
pull[bot] merged 2 commits into
ConnectionMaster:masterfrom
DataDog:master

Conversation

@pull

@pull pull Bot commented Jun 16, 2026

Copy link
Copy Markdown

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.4)

Can you help keep this open source service alive? 💖 Please sponsor : )

eric-weaver and others added 2 commits June 15, 2026 22:00
…#24056)

* Properly cache and ignore DDIGNORE labeled queries

* partial commit miss

* remove test dashboard

* Fix edge case on cache correctness
* test argocd submission

* add unique identifier

* better unique identifier

* allow list approach

* validations

* argocd to submit entity metadata

* Update 23917.added

* remove public plication

* Update metadata.csv

* use a different separator

* pin dcb

* remove review files

* fix naming

* clean up

* more knobs

* nits

* Read genresources config from pydantic and clean up reviewer findings

- Defer ArgocdResourceCollector construction to the first check() call so
  it observes the populated pydantic config (self.config) instead of the
  raw instance dict; drops the hardcoded TTL / interval / cap literals
  that were duplicating the spec defaults.
- Read collect_genresources from self.config.
- Swap the volume-cap log args to read type/fetched/cap in order and use
  log.exception for the fetch-failure path so tracebacks survive.
- Spec wording: ArgoCD (one word) and allowlist / allowlisted per the
  style guide.
- Tests: add a _check() helper that loads the config models and attaches
  the collector, add coverage for the missing-endpoint path and for
  credential scrubbing on cluster.connectionState.message, tighten the
  volume-cap assertion against the new message format, and mark the file
  as pytest.mark.unit.

* Update argocd/datadog_checks/argocd/resources.py

Co-authored-by: Kyle Neale <kyle.neale@datadoghq.com>

* Update argocd/datadog_checks/argocd/resources.py

Co-authored-by: Kyle Neale <kyle.neale@datadoghq.com>

* Update argocd/datadog_checks/argocd/resources.py

Co-authored-by: Kyle Neale <kyle.neale@datadoghq.com>

* Update argocd/datadog_checks/argocd/resources.py

Co-authored-by: Kyle Neale <kyle.neale@datadoghq.com>

---------

Co-authored-by: Kyle-Neale <kyle.neale@datadoghq.com>
@pull pull Bot locked and limited conversation to collaborators Jun 16, 2026
@pull pull Bot added the ⤵️ pull label Jun 16, 2026
@pull pull Bot merged commit 3101d3f into ConnectionMaster:master Jun 16, 2026
8 of 11 checks passed
@pull pull Bot had a problem deploying to typo-squatting-release June 16, 2026 08:45 Failure
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants